Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open tagbot trigger issues for testitem repos #569

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

davidanthoff
Copy link
Contributor

Repos that use the julia-vscode/testitem-workflow/.github/workflows/juliaci.yml are also TagBot enabled.

@davidanthoff davidanthoff changed the title Open tagbot triger issues for testitem repos Open tagbot trigger issues for testitem repos Jul 22, 2024
@DilumAluthge
Copy link
Member

Hmmm. So, IIUC, this code is looking for the text JuliaRegistries/TagBot in the contents of the file (not the filename).

So I'm wondering why it's not already working, given that the https://github.com/julia-vscode/testitem-workflow/blob/main/.github/workflows/juliaci.yml file already includes the text JuliaRegistries/TagBot in the file contents.

@DilumAluthge
Copy link
Member

Disregard my previous comment. I was looking at https://github.com/julia-vscode/testitem-workflow/blob/main/.github/workflows/juliaci.yml, but I should have been looking at https://github.com/davidanthoff/StringBuilders.jl/blob/master/.github/workflows/juliaci.yml.

And that latter file (https://github.com/davidanthoff/StringBuilders.jl/blob/master/.github/workflows/juliaci.yml) does indeed include the text (in its file contents) that this PR is looking for.

@DilumAluthge DilumAluthge added this pull request to the merge queue Jul 22, 2024
Merged via the queue into master with commit e32955e Jul 22, 2024
10 of 11 checks passed
@DilumAluthge DilumAluthge deleted the testitem-workflow-tagbot branch July 22, 2024 15:33
@ericphanson
Copy link
Member

btw to be deployed, we need to first bump the version and merge & tag that

@davidanthoff
Copy link
Contributor Author

Should I be doing something to trigger that? Probably makes more sense for someone who is more in charge of this repo to do that?

@ericphanson
Copy link
Member

if it wasn't already merged I'd have asked you to include the version bump as part of the PR. Changes are infrequent currently so IMO it's better to just release whenever there's a change, otherwise it will be a long time until the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants